Skip to content

Fix submodule path #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix submodule path #1672

wants to merge 1 commit into from

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 7, 2025

It was containing a commit from senekor's fork, but it was pointing to the upstream repo.

@Kobzol Kobzol mentioned this pull request Aug 7, 2025
@senekor
Copy link
Contributor

senekor commented Aug 7, 2025

That's not what we want though, we don't want to use my fork indefinitely. Upstream should work for us now.

@Kobzol
Copy link
Member Author

Kobzol commented Aug 7, 2025

I tried it with local zola and got an error because of the permalink. I'll try with the latest version now.

@Kobzol
Copy link
Member Author

Kobzol commented Aug 7, 2025

In general, checking out the recursive submodules and building Zola is... interesting. I would perhaps point people to https://www.getzola.org/documentation/getting-started/installation/ or even better to https://github.com/getzola/zola/releases/tag/v0.21.0, it IMO seems easier than building a 500+ dependency binary in release mode with LTO and CGU=1 and fetching tens of submodules.

@senekor
Copy link
Contributor

senekor commented Aug 7, 2025

IIRC @Manishearth is against telling people to install random binaries we don't control.

@Kobzol
Copy link
Member Author

Kobzol commented Aug 7, 2025

Hmm, while I get that sentiment, I'm not sure if it's that much better if we tell them to checkout 25 submodules and build 500+ Rust dependencies, which we also don't control. We kind of gave up "control" when it was decided to switch from in-tree Rust rendering to Zola.

@senekor
Copy link
Contributor

senekor commented Aug 7, 2025

Right, but building from a commit hash is more deterministic than downloading binaries from a URL.

@Kobzol
Copy link
Member Author

Kobzol commented Aug 7, 2025

Can't argue with that, although we could add some helper script that verifies the binary SHA, that shouldn't be that difficult.

I just see it as a contributor roadblock currently, because building the Zola binary is really resource intensive, both network and CPU wise, and takes 5+ minutes even on a relatively powerful laptop. Of course it only has to be done "once in a while", but people don't write blog posts that often, so it is (IMO a big) annoyance. So from my POV it would be worth it to simplify this as much as possible.

In the extreme case, we could build the binaries on the blog's CI and let people download it from there, but that's IMO too complicated.

@senekor
Copy link
Contributor

senekor commented Aug 7, 2025

I definitely agree with the fact that it's annoying. Not sure what the best solution is.

@Kobzol Kobzol marked this pull request as draft August 7, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants